Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Relaxed CodeLocationsTest and co. #3849

Merged
merged 7 commits into from
Nov 4, 2022
Merged

Relaxed CodeLocationsTest and co. #3849

merged 7 commits into from
Nov 4, 2022

Conversation

JaroslavTulach
Copy link
Member

@JaroslavTulach JaroslavTulach commented Nov 3, 2022 •
edited
Loading

Pull Request Description

Another set of fixes extracted from #3611. CodeLocationsTest test has been made more flexible to allow "off by one" differences in the offset locations between the old and new parser.

Checklist

Please include the following checklist in your PR:

  • All code conforms to the Scala, Java, style guides.
  • All code has been tested:
    • Unit tests have been written where possible.

@JaroslavTulach JaroslavTulach added CI: Ready to merge This PR is eligible for automatic merge CI: No changelog needed Do not require a changelog entry for this PR. labels Nov 3, 2022
@JaroslavTulach JaroslavTulach requested a review from kazcw November 3, 2022 06:50
@JaroslavTulach JaroslavTulach self-assigned this Nov 3, 2022
hubertp
hubertp reviewed Nov 3, 2022
View reviewed changes
Copy link
Collaborator

@hubertp hubertp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would be useful to have comments in various places where locations are manipulated.

engine/runtime/src/main/java/org/enso/compiler/TreeToIr.java Show resolved Hide resolved
engine/runtime/src/main/java/org/enso/compiler/TreeToIr.java Show resolved Hide resolved
engine/runtime/src/main/java/org/enso/compiler/TreeToIr.java Show resolved Hide resolved
engine/runtime/src/main/java/org/enso/compiler/TreeToIr.java Outdated Show resolved Hide resolved
engine/runtime/src/main/java/org/enso/compiler/TreeToIr.java Outdated Show resolved Hide resolved
@JaroslavTulach
Copy link
Member Author

I think it would be useful to have comments in various places where locations are manipulated.

OK, I've just renamed the local variables to describe their purpose. Btw. the cases are covered by associated unit tests.

@mergify mergify bot merged commit 56a4b88 into develop Nov 4, 2022
@mergify mergify bot deleted the wip/jtulach/RelaxedCodeLocationsTest_182743471 branch November 4, 2022 06:04
@wdanilo wdanilo mentioned this pull request Feb 6, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hubertp hubertp hubertp approved these changes

@kazcw kazcw Awaiting requested review from kazcw

@4e6 4e6 Awaiting requested review from 4e6 4e6 is a code owner

Assignees

@JaroslavTulach JaroslavTulach

Labels
CI: No changelog needed Do not require a changelog entry for this PR. CI: Ready to merge This PR is eligible for automatic merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JaroslavTulach @hubertp